Quantcast
Channel: Seerah's Portal - Bug Comments (WoWInterface)
Viewing all articles
Browse latest Browse all 76

Integer overflow killing world boss - I think I see what the...

$
0
0
I think I see what the issue is here... The text tries to update itself whenever the statusbar changes or the mouseover unit changes. If you move your mouse off of a unit at the same moment the code tries to run, the mouseover unit no longer exists and a max health value of 0 is returned by the client.Previously, I had just manually changed the 0 to a 1 to account for the division by 0 errors. However, with the HUUUUGE pools of health of today's bosses, dividing by max health and multiplying by 100 to get the percent results in a number too large for Lua to store in a variable (when the max health is set to 1).Instead, I will probably cancel updating the text instead of manually switching it from 0 to 1. I would like to test it for a bit myself to make sure that it doesn't break anything before uploading the fix. In the mean time, you can switch to a text that doesn't display the percentage, or you can manually make this simple change yourself in the Lua file.In tiptop.lua (you can open this with any text editor), search for the linelocal function CalcHealth(_,hp)Just below that will be this lineif maxhp 0 then maxhp = 1 endRemove that line and replace it with thisif maxhp 0 thenreturn end(Interface: TipTop | Bug: Integer overflow killing world boss)

Viewing all articles
Browse latest Browse all 76

Trending Articles